Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #4330

Closed
wants to merge 22 commits into from
Closed

Fix broken link #4330

wants to merge 22 commits into from

Conversation

mvasin
Copy link
Contributor

@mvasin mvasin commented Apr 20, 2018

No description provided.

bondz and others added 21 commits January 18, 2018 11:55
Update User Guide's README.md to include `json` and `css`
files in the command to format the entire project for the first time
with prettier, that it's consistent with the `lint-staged` command.
This reverts commit bab2c29.

I meant to apply it to `next` instead.
 - create-react-app@1.5.2
 - react-scripts@1.1.1
Support for .mjs files added in #3239 did not account for npm libraries which ship native mjs files alongside js files. This accounts for this by ensuring .js files resolve before their accompanying .mjs file. Note that this is not an ideal end state since selecting a .mjs over a .js extension should be the result of whether `import` was used instead of `require()` in a node environment with native ESM support (currently via `--experimental-modules`). Instead, this change just *always* selects a .js extension before the .mjs extension if it exists.

This unbreaks support for using GraphQL (relay, apollo, etc) within create-react-app projects.
Add troubleshooting for an issue that has to do with either 2FA, or using Windows, or both, when trying to deploy an app via gh-pages
 - react-scripts@1.1.2
 - react-scripts@1.1.3
 - react-dev-utils@5.0.1
 - react-scripts@1.1.4
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer
Copy link
Contributor

Timer commented Apr 21, 2018

Can you please target this at next?

@mvasin mvasin changed the base branch from master to next April 21, 2018 07:05
@mvasin
Copy link
Contributor Author

mvasin commented Apr 21, 2018

@Timer Sure, there you have it. Now how do we get rid of "Merge branch 'next' into patch-1" commit from the commit history?

@Timer
Copy link
Contributor

Timer commented Apr 21, 2018

It may be easier to re-submit this PR against next via closing it and re-editing.

@mvasin
Copy link
Contributor Author

mvasin commented Apr 21, 2018

@Timer I'll try to figure out the right way, without re-submitting the issue.

@mvasin
Copy link
Contributor Author

mvasin commented Apr 21, 2018

Seems like the fixed link has already made it to the next branch with someone else's commit, so I'll just close this issue.

@mvasin mvasin closed this Apr 21, 2018
@mvasin mvasin deleted the patch-1 branch April 21, 2018 17:48
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants