Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update createReactApp.js #4359

Closed
wants to merge 1 commit into from
Closed

Update createReactApp.js #4359

wants to merge 1 commit into from

Conversation

retyui
Copy link

@retyui retyui commented Apr 25, 2018

node -v // 10.x
yarn -v // 1.6.x
create-react-app --version  // 1.5.2

My problem:

Creating a new React app in /home/o/work/fire.

Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts...

yarn add v1.6.0
info No lockfile found.
[1/4] Resolving packages...
info There appears to be trouble with your network connection. Retrying...
[2/4] Fetching packages...
info fsevents@1.2.2: The platform "linux" is incompatible with this module.
info "fsevents@1.2.2" is an optional dependency and failed compatibility check. Excluding it from installation.
error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Aborting installation.
  yarnpkg add --exact react react-dom react-scripts --cwd /home/o/work/fire has failed.

Deleting generated file... package.json
Deleting fire/ from /home/o/work

```
node -v // 10.x
yarn -v // 1.6.x
create-react-app --version  // 2.0.0-next.66cc7a90
```
# My problem:
```bash

Creating a new React app in /home/o/work/fire.

Installing packages. This might take a couple of minutes.
Installing react, react-dom, and react-scripts...

yarn add v1.6.0
info No lockfile found.
[1/4] Resolving packages...
info There appears to be trouble with your network connection. Retrying...
[2/4] Fetching packages...
info fsevents@1.2.2: The platform "linux" is incompatible with this module.
info "fsevents@1.2.2" is an optional dependency and failed compatibility check. Excluding it from installation.
error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

Aborting installation.
  yarnpkg add --exact react react-dom react-scripts --cwd /home/o/work/fire has failed.

Deleting generated file... package.json
Deleting fire/ from /home/o/work
```
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu
Copy link
Contributor

iansu commented Apr 25, 2018

I don't know if this is necessarily the right way to fix this. The issue here is that upath doesn't explicitly support node 10. Ignoring the engines field everywhere seems like a hack. Have you filed an issue with upath?

@retyui
Copy link
Author

retyui commented Apr 25, 2018

@iansu
Сan it be better to add a choice to users? Ignore or not engine!
Because now users(node v10) can't use your tool, because of some third-party module!

@wopian
Copy link

wopian commented Apr 26, 2018

This'll be resolved when anodynos/upath#15 gets merged and published

panmona added a commit to ultimate-ttt/ultimate-ttt that referenced this pull request Apr 26, 2018
@retyui
Copy link
Author

retyui commented Apr 26, 2018

#4367

@iansu
Copy link
Contributor

iansu commented Apr 26, 2018

Since we have a temporary workaround and a pending fix in upath I'm going to close this PR.

@iansu iansu closed this Apr 26, 2018
@anodynos
Copy link

Hello everyone - I merged anodynos/upath#15 & published it - thanks & sorry for the delay! You can complete the issue, once you check its working.

@Timer
Copy link
Contributor

Timer commented Apr 27, 2018

Thanks for the notification, @anodynos. 😄

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants