Make Sass missing message friendlier #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
approved these changes
May 25, 2018
| lines[1] = 'You need to install `node-sass` to compile Sass files.\n'; | ||
| lines[1] += | ||
| 'Please run `npm i node-sass` or `yarn add node-sass` inside your workspace.'; | ||
| } |
There was a problem hiding this comment.
Does npm command need save? What if they use an older npm?
| @@ -101,6 +101,12 @@ function formatMessage(message, isError) { | |||
| ); | |||
| } | |||
|
|
|||
| if (lines[1].match(/sass-loader.+node-sass.+install/)) { | |||
| lines[1] = 'You need to install `node-sass` to compile Sass files.\n'; | |||
There was a problem hiding this comment.
Maybe “To import Sass files in this project, you [...]”
gaearon
reviewed
Sep 26, 2018
| - [`Object.assign()`](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Object/assign) via [`object-assign`](https://github.com/sindresorhus/object-assign). | ||
| - [`Promise`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise) via [`promise`](https://github.com/then/promise). | ||
| - [`fetch()`](https://developer.mozilla.org/en/docs/Web/API/Fetch_API) via [`whatwg-fetch`](https://github.com/github/fetch). | ||
| Note that **this project includes no [polyfills](https://en.wikipedia.org/wiki/Polyfill)** by default. | ||
|
|
||
| If you use any other ES6+ features that need **runtime support** (such as `Array.from()` or `Symbol`), make sure you are including the appropriate polyfills manually, or that the browsers you are targeting already support them. |
There was a problem hiding this comment.
Shouldn't this section link to our polyfill instructions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
