Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured the thread-loader to keeping workers alive in development mode #4562

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Conversation

sadkovoy
Copy link

@sadkovoy sadkovoy commented Jun 5, 2018

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon merged commit d0afe4b into facebook:next Jun 5, 2018
@gaearon
Copy link
Contributor

gaearon commented Jun 5, 2018

Thanks! This does feel better.

The rebuild performance is still somewhat slower on next branch than on master. Would you like to look into why?

@sadkovoy sadkovoy deleted the #4346 branch June 5, 2018 17:10
@Timer Timer added this to the 2.0.0 milestone Jun 5, 2018
@sadkovoy
Copy link
Author

sadkovoy commented Jun 6, 2018

Ok, I'll try to compare and debug. Could you close the related issue?

@viankakrisna
Copy link
Contributor

viankakrisna commented Jun 6, 2018

cmiiw, but isn't this make more sense in app thread-loader instead of dependencies thread-loader?

do we retranspile dependencies on every rebuild?

@iansu
Copy link
Contributor

iansu commented Jun 6, 2018

@viankakrisna That is an excellent point. Nice catch. I think this should either be used in both places or just for the app code. What do other people think?

@gaearon
Copy link
Contributor

gaearon commented Jun 6, 2018

Should be used in both places I imagine.

@sadkovoy
Copy link
Author

sadkovoy commented Jun 7, 2018

Oh, thank you! PR: #4582

zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants