-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configured the thread-loader to keeping workers alive in development mode #4562
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks! This does feel better. The rebuild performance is still somewhat slower on |
Ok, I'll try to compare and debug. Could you close the related issue? |
cmiiw, but isn't this make more sense in app thread-loader instead of dependencies thread-loader?
|
@viankakrisna That is an excellent point. Nice catch. I think this should either be used in both places or just for the app code. What do other people think? |
Should be used in both places I imagine. |
Oh, thank you! PR: #4582 |
#4346