Strip flow syntax before any other transform #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins run before presets so we can't use the flow preset
gaearon
reviewed
Sep 30, 2018
| ].filter(Boolean), | ||
| plugins: [ | ||
| // Strip flow types before any other transform, emulating the behavior | ||
| // order as-if the browser supported all of the succeeding features | ||
| isFlowEnabled && |
There was a problem hiding this comment.
Let's link to the issue here
gaearon
approved these changes
Sep 30, 2018
|
Yes, it fixed the issue. 😄 |
Merged
|
See e2e #5183 |
11 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins run before presets so we can't use the flow preset
As pointed out by @gaearon, this would be the natural order if the browser supported class properties (or any other transform).
Fixes #5176