Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jest #530

Merged
merged 7 commits into from
Sep 1, 2016
Merged

Update Jest #530

merged 7 commits into from
Sep 1, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Aug 31, 2016

Needs another fix scheduled for 15.0.1 but should be almost good to go.

@ghost ghost added the CLA Signed label Aug 31, 2016
@vjeux
Copy link
Contributor

vjeux commented Aug 31, 2016

lgtm, the test file is very simple, I like it :)

test -e src/__tests__/__snapshots__/App-test.js.snap
npm test -- --smoke-test
# Uncomment when snapshot testing is enabled by default:
# test -e src/__tests__/__snapshots__/App-test.js.snap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean App.spec.js here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's disabled this doesn't really matter—when we re-add it we can revisit naming and where we put it.

@gaearon gaearon merged commit 67fe759 into facebook:master Sep 1, 2016
@gaearon gaearon added this to the 0.3.0 milestone Sep 1, 2016
@cpojer
Copy link
Contributor

cpojer commented Sep 1, 2016

boom.

@gaearon gaearon deleted the update-jest branch September 1, 2016 09:07
@gaearon gaearon mentioned this pull request Sep 1, 2016
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
* Update Jest

* Remove default snapshot test

* Fix a few things

* Add a simple default test

* App.spec.js -> App.test.js

* Fix e2e test

* Bump Jest
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
* Update Jest

* Remove default snapshot test

* Fix a few things

* Add a simple default test

* App.spec.js -> App.test.js

* Fix e2e test

* Bump Jest
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants