Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README due to deprecation of react-testing-library's toBeInTheDOM #5334

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Update README due to deprecation of react-testing-library's toBeInTheDOM #5334

merged 1 commit into from
Oct 6, 2018

Conversation

rrebase
Copy link
Contributor

@rrebase rrebase commented Oct 6, 2018 •
edited
Loading

The react-testing-library deprecated toBeInTheDOM in favor of toBeInTheDocument.

See testing-library/jest-dom@3601efd

@Timer Timer added this to the 2.0.5 milestone Oct 6, 2018
@Timer
Copy link
Contributor

Timer commented Oct 6, 2018

/cc @kentcdodds

@Timer Timer merged commit 12f794c into facebook:master Oct 6, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@rrebase @Timer
Update README due to deprecation of react-testing-library's toBeInThe…
b08ff4e 
…DOM (facebook#5334)
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@rrebase @Timer @facebook-github-bot