Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix title on Safari #5499

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Fix title on Safari #5499

merged 1 commit into from
Oct 21, 2018

Conversation

yuyokk
Copy link
Contributor

@yuyokk yuyokk commented Oct 20, 2018

Hello,

I see that title wraps on Safari so I prepared a small PR to fix this. Here is how it looks with a fix applied.

Please check and let me know if this makes sense.

Thanks 🙏

@Timer Timer requested a review from selbekk October 21, 2018 02:05
selbekk
selbekk approved these changes Oct 21, 2018
View reviewed changes
Copy link
Contributor

@selbekk selbekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@Timer Timer added this to the 2.0.6 milestone Oct 21, 2018
@Timer Timer merged commit 7ae01d6 into facebook:master Oct 21, 2018
@yuyokk yuyokk deleted the fix-safari-title branch October 21, 2018 17:15
@Timer Timer modified the milestones: 2.0.6, 2.1 Oct 22, 2018
nate770 pushed a commit to ONTW/create-react-app that referenced this pull request Oct 30, 2018
@yuyokk @nate770
Fix title on Safari (facebook#5499)
a3956b5
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@selbekk selbekk selbekk approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@yuyokk @selbekk @Timer @facebook-github-bot