Remove react-scripts type reference on eject #5611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wtf, no clue why this test is failing. It works locally. This is the last blocker for the 2.1 release. |
|
Having trouble running the |
|
The |
|
@brunolemos that's the old behavior, note the file is no longer in This PR should be writing the file correctly: https://github.com/facebook/create-react-app/pull/5611/files#diff-64d71298908161d0a835f0b72170c307R256 |
nate770
pushed a commit
to ONTW/create-react-app
that referenced
this pull request
Oct 30, 2018
* Remove react-scripts type reference on eject * Check for env file * Check eject for typescript * Shuffle appTypeDeclarations * Append internal types on eject * Ensure lib is published for types * Adjust comment * Don't add a bunch of new lines * File should exist and not be deleted * Add debug * Set file explicitly * Revert "Set file explicitly" This reverts commit bcd58a3. * Copy file before destroying ourselves * Revert "Add debug" This reverts commit 0068ba8.
mrmckeb
pushed a commit
to BeameryHQ/bmr-react-scripts
that referenced
this pull request
Oct 31, 2018
* Remove react-scripts type reference on eject * Check for env file * Check eject for typescript * Shuffle appTypeDeclarations * Append internal types on eject * Ensure lib is published for types * Adjust comment * Don't add a bunch of new lines * File should exist and not be deleted * Add debug * Set file explicitly * Revert "Set file explicitly" This reverts commit bcd58a3. * Copy file before destroying ourselves * Revert "Add debug" This reverts commit 0068ba8.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5596 by removing our added file