Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest installing enzyme as dev dependency #5657

Closed
wants to merge 1 commit into from
Closed

Suggest installing enzyme as dev dependency #5657

wants to merge 1 commit into from

Conversation

JBallin
Copy link
Contributor

@JBallin JBallin commented Oct 31, 2018

No description provided.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@bugzpodder
Copy link

This is expected as we don't recommend user installing dev-dependencies. Please see previous issues for an explanation. Thanks!

@bugzpodder bugzpodder closed this Oct 31, 2018
@JBallin
Copy link
Contributor Author

JBallin commented Oct 31, 2018

Sorry for not finding those previous issues!

This comment in #2696 explains that Dan has thoughtfully considered this issue and has decided to keep everything in dependencies. While I have arguments otherwise (and don't feel like there's a good explanation given), I trust and respect his decision.

This is a good example of an issue that can be debated endlessly because there's very little technical arguments for and against. I've made a choice there and if you disagree, you can always move those few lines.

@JBallin JBallin deleted the docs-tests-dev branch October 31, 2018 23:31
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants