Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass source map for dev #5713

Merged
merged 5 commits into from
Feb 8, 2019
Merged

Sass source map for dev #5713

merged 5 commits into from
Feb 8, 2019

Conversation

alicialics
Copy link
Contributor

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Copy link

@bugzpodder bugzpodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it looks great. Thank you!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz
Copy link
Contributor

@bugzpodder
Copy link

cc @Fabianopb
According to https://github.com/webpack-contrib/sass-loader#source-maps it didn't say it was needed on style-loader. this set of changes on dev is consistent with the config on prod, I would imagine that it should be added two both configs if deemed necessary.

@Fabianopb
Copy link
Contributor

It's been many months, but I had in my mind that it wasn't necessary to enable sourceMap in style-loader because I remember seeing this documentation that @bugzpodder referenced here.

But, not sure now, as @ianschmitz noticed from the style-loader docs, it seems to be required.

Apparently we have conflicting information, should we ask someone from webpack-contrib to confirm?

@stale
Copy link

stale bot commented Dec 5, 2018

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 5, 2018
@ianschmitz ianschmitz removed the stale label Dec 9, 2018
@stale
Copy link

stale bot commented Jan 12, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 12, 2019
@ianschmitz ianschmitz removed the stale label Jan 16, 2019
@ianschmitz ianschmitz added this to the 2.1.x milestone Jan 16, 2019
@bugzpodder
Copy link

@zhuoli99 Can you rebase this diff with the latest webpack config changes? Thanks!

@bugzpodder bugzpodder merged commit 18d5e87 into facebook:master Feb 8, 2019
mrmckeb pushed a commit to BeameryHQ/bmr-react-scripts that referenced this pull request Feb 11, 2019
@lock lock bot locked and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants