Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies in babel-preset-react-app #5818

Merged
merged 5 commits into from
Aug 9, 2019
Merged

Remove unused dependencies in babel-preset-react-app #5818

merged 5 commits into from
Aug 9, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Nov 15, 2018

Closes #5165

Timer
Timer approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

@Timer Timer added this to the 2.1.2 milestone Nov 15, 2018
@iansu
Copy link
Contributor Author

iansu commented Nov 15, 2018

That's my plan for checking if they're really unused. 😀

@iansu
Copy link
Contributor Author

iansu commented Nov 15, 2018

It looks like SVGR might need some of these. Let's try this again after we upgrade to SVGR 4: #5816

@Timer Timer modified the milestones: 2.1.2, 2.1.3 Dec 23, 2018
@ianschmitz ianschmitz modified the milestones: 2.1.3, 2.1.4 Jan 4, 2019
@ianschmitz
Copy link
Contributor

Related: #6124

@ianschmitz ianschmitz modified the milestones: 2.1.4, 2.1.5 Feb 10, 2019
@iansu iansu modified the milestones: 2.1.6, 2.1.x, 3.x Mar 6, 2019
@ianschmitz ianschmitz modified the milestones: 3.x, 3.1 Aug 4, 2019
@ianschmitz
Copy link
Contributor

Seems some of these are still required?

./src/index.tsx | Error: [BABEL] /home/vsts/work/_temp/tmp.AAcKXmwFdW/test-app-typescript/src/index.tsx: Cannot find module '@babel/plugin-transform-react-display-name' (While processing: "/home/vsts/work/_temp/tmp.AAcKXmwFdW/test-app-typescript/node_modules/babel-preset-react-app/index.js$1")

@iansu
Copy link
Contributor Author

iansu commented Aug 9, 2019

Well, CI passed. How confident are we in our tests? 😀

@iansu iansu merged commit f09d3d3 into facebook:master Aug 9, 2019
@iansu iansu deleted the babel-preset-react-app-unused-deps branch August 9, 2019 20:04
@iansu
Copy link
Contributor Author

iansu commented Aug 9, 2019

YOLO

@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@bugzpodder bugzpodder Awaiting requested review from bugzpodder

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

Unused depedencies in babel-preset-react-app?
4 participants
@iansu @ianschmitz @Timer @facebook-github-bot