Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for using local images #589

Closed
wants to merge 1 commit into from
Closed

Added instructions for using local images #589

wants to merge 1 commit into from

Conversation

iRoachie
Copy link
Contributor

@iRoachie iRoachie commented Sep 5, 2016

References #585

@ghost
Copy link

ghost commented Sep 5, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Sep 5, 2016
@ghost
Copy link

ghost commented Sep 5, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Sep 21, 2016

Cherry-picked via d2128b6. I tweaked the first sentence a little bit. Thanks, and sorry for long review!

@gaearon gaearon closed this Sep 21, 2016
@iRoachie
Copy link
Contributor Author

Np. Glad i could help!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants