Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Hot reloading (only for Hooks) #5958

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Dec 3, 2018

I don't know if this is going to work but I'm going to try another time. Hooks were another piece of the puzzle. Maybe it'll work out.

Preserving state is Hooks-only. It's too brittle for classes. With Hooks it "just works" by design.

@gaearon gaearon changed the title [WIP] Hot reloading [WIP] Hot reloading (only for Hooks) Dec 3, 2018
@netlify
Copy link

netlify bot commented Dec 3, 2018

Deploy preview for create-react-app ready!

Built with commit 43e5f2e

https://deploy-preview-5958--create-react-app.netlify.com

@gaearon gaearon force-pushed the hot-reload-again branch 2 times, most recently from 7066e8a to 543ff93 Compare December 4, 2018 10:25
@stale
Copy link

stale bot commented Jan 12, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 12, 2019
@ianschmitz ianschmitz removed the stale label Jan 12, 2019
@stale
Copy link

stale bot commented Feb 11, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 11, 2019
@gausie
Copy link

gausie commented Feb 11, 2019

Please bot do not stale 🙏🤖

@stale stale bot removed the stale label Feb 11, 2019
@stale
Copy link

stale bot commented Mar 13, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@IronSean
Copy link

Where is this at? What can be done to help?

@bjunix
Copy link

bjunix commented Jan 17, 2020

Where is this at? What can be done to help?

Looks like the discussion is moved here: facebook/react#16604 (comment)

@mihanizm56
Copy link

mihanizm56 commented May 24, 2020

A lot of apps are written with classes.
This is a breaking change for them =(((
Why not to do it for class-components ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants