add command to add files to staging after eject #5960
Conversation
|
Deploy preview for create-react-app ready! Built with commit 209e28f7d8ea28cee8a985e67224732ffa3d5f1f |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
It would be nice if we could add a basic test for this, maybe in |
|
I think thats a good suggestion Would something like this suffice? |
|
Yes, a git command like that should do it. I'm not a bash expert but I think you can do something like |
|
I imagine if this fails it's not a big deal? Maybe we can remove the log info and wrap it in a try catch that swallows the error? Also, we need the git detection before trying this right? |
|
That's a good catch @Timer. Wrapping it in a try catch would serve as a git detection as well. |
| } | ||
| ); | ||
| } catch (e) { | ||
| return ''; |
There was a problem hiding this comment.
You can probably just return instead of returning an empty string. What get's returned if this succeeds?
There was a problem hiding this comment.
I thought about just returning but then I saw we're retuning an empty string on line #37 so I did to keep it consistent.
I forgot to return true so I'll add that in. 😓
There was a problem hiding this comment.
That other function returns a string on success and an empty string on failure. If this function returns true on success then it should return false on failure.
| @@ -310,6 +324,11 @@ inquirer | |||
| console.log(green('Ejected successfully!')); | |||
| console.log(); | |||
|
|
|||
| if (tryGitAdd(appPath)) { | |||
| console.log(cyan('Added ejected files to Staging for commit.')); | |||
There was a problem hiding this comment.
The message can probably just be: Staged ejected files for for commit.
There was a problem hiding this comment.
for for was a typo. Please remove one of them.
|
Please add the test that we discussed earlier. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Hey @iansu, not sure if you saw but I added the test we discussed. 😄 |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
iansu
requested review from
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
mrmckeb,
petetnt and
Timer
as code owners
|
Thanks! |
* masterd: (24 commits) Add TypeScript linting support (facebook#6513) Support React Hooks (facebook#5602) (facebook#5997) Support browserslist in @babel/preset-env (facebook#6608) Add empty mock for http2 (facebook#5686) Add note about npx caching (facebook#6374) change named import into default import (facebook#6625) Stage files for commit after ejecting (facebook#5960) Upgrade dependencies (facebook#6614) Make compiler variable const instead of let (facebook#6621) Type check JSON files (facebook#6615) Change class components to functional components in templates (facebook#6451) Convert JSON.stringify \n to os.EOL when writing tsconfig.json (facebook#6610) Update html-webpack-plugin (facebook#6361) Enable click to go to error in console for TypeScript (facebook#6502) Update webpack-dev-server to 3.2.1 (facebook#6483) [docs] revert removal of newlines from html (facebook#6386) Publish Prepare 2.1.8 release Reapply "Speed up TypeScript v2 (facebook#6406)" (facebook#6586) Publish ... # Conflicts: # packages/babel-preset-react-app/create.js # packages/react-scripts/scripts/build.js
#5953 - This adds the scripts & config folder to the git staging area after the app is ejected.