Misc fixes for Windows #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,38 +55,11 @@ | |||
| "webpack-dev-server": "1.14.1" | |||
| }, | |||
| "devDependencies": { | |||
| "bundle-deps": "^1.0.0", | |||
There was a problem hiding this comment.
This utility writes bundledDependencies to package.json so we don’t have to maintain two lists
ghost
added
the
| "webpack", | ||
| "webpack-dev-server" | ||
| ] | ||
| "optionalDependencies": { |
There was a problem hiding this comment.
Webpack depends on Watchpack depends on Chokidar depends on fsevents.
fsevents is OS X-only.
If we naïvely include webpack into bundledDependencies (which we want to do), fsevents ends up there as well, and Windows machines fail to install the whole bundle.
The solution I’m using is the following:
- Populate bundled dependencies as prepublish step
- Delete
node_modules/fseventsjust before publishing so it doesn't get bundled - However! It exists in
optionalDependenciesso it'll get installed separately on supported systems
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing how some things work + adding a release script.
Don’t run it 😄