Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docusaurus and enable new features #6365

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Upgrade Docusaurus and enable new features #6365

merged 1 commit into from
Feb 13, 2019

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Feb 8, 2019

Docusaurus maintainer here 👋

Docusaurus has released a number of versions and many new features have been added. This PR updates the docs to the latest version of Docusaurus and enables the useful new features, namely:

  • Last update author and time for a doc
  • Collapsible side navigation (useful for websites with a large number of pages like CRA)
  • Scroll to top button

These features are captured nicely within this screenshot:

screen shot 2019-02-08 at 10 28 29 pm

Have a go at the Netlify preview to test it more in-depth.

If you don't want to enable certain features, I can omit them from the PR.

@ianschmitz
Copy link
Contributor

Thanks for the PR @yangshun!

@amyrlam what do you think of the changes?

Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangshun thanks for the update!

@amyrlam
Copy link
Contributor

amyrlam commented Feb 12, 2019

There were a bunch of failing builds, most were fixed by rerunning the build.

Still two failures that I don't know how to debug yet: https://travis-ci.org/facebook/create-react-app/jobs/490576664#L3208 and https://travis-ci.org/facebook/create-react-app/jobs/490576673#L551

@amyrlam
Copy link
Contributor

amyrlam commented Feb 13, 2019

From @iansu: Test are unrelated to docs changes, so a-ok to merge the PR

@amyrlam amyrlam merged commit 8944aab into facebook:master Feb 13, 2019
@ianschmitz ianschmitz modified the milestones: 2.1.x, 2.1.5 Feb 13, 2019
@lock lock bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants