Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use contenthash instead of chunkhash for better long-term caching #6387

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

ianschmitz
Copy link
Contributor

This changes the .js webpack file name values to use contenthash instead of chunkhash as recommended by the webpack team:

webpack/webpack.js.org#2096
https://webpack.js.org/guides/caching/#output-filenames

This should improve long-term caching for our users by relying only on the contents of the .js file itself instead of the chunk as a whole (.js, .css, etc) to generate the filename.

@ianschmitz ianschmitz added this to the 2.1.x milestone Feb 10, 2019
@ianschmitz ianschmitz modified the milestones: 2.1.x, 2.1.6 Feb 20, 2019
@ianschmitz ianschmitz closed this Feb 21, 2019
@ianschmitz ianschmitz reopened this Feb 21, 2019
@ianschmitz ianschmitz merged commit 6c8e2e5 into facebook:master Feb 21, 2019
@ianschmitz ianschmitz deleted the webpack-js-hash branch February 21, 2019 02:24
@lock lock bot locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants