Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload app when paths.appHtml changes #656 #657

Closed
wants to merge 1 commit into from

Conversation

whichsteveyp
Copy link

No description provided.

@ghost ghost added the CLA Signed label Sep 15, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 16, 2016

I think this is not the right place to do it, even though it technically works. Maybe we should file an issue in https://github.com/ampedandwired/html-webpack-plugin?

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works but this is not a correct fix. The HTML file should get watched because it’s being served (perhaps somewhere in html-webpack-plugin), not because we added it to a JS entry point.

@whichsteveyp
Copy link
Author

Agreed it should be resolved in the correct place, mostly opened this PR as a reference to 'something that happened to fix it' when I was tinkering around with the webpack internals for the first time.

I'll look at the html-webpack-plugin and see if I can learn anything about that &&|| open an issue there. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Sep 30, 2016

I’ll close this for now. Let’s track a better solution in #656.
Thank you!

@gaearon gaearon closed this Sep 30, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants