Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for special scripts versions #681

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Conversation

yesmeck
Copy link
Contributor

@yesmeck yesmeck commented Sep 19, 2016

I published a react-scripts-fork package to npm for testing.

@ghost ghost added the CLA Signed label Sep 19, 2016
# Test special scripts versions
create_react_app --scripts-version=0.4.0 test-app-version-number
create_react_app --scripts-version=https://registry.npmjs.org/react-scripts/-/react-scripts-0.4.0.tgz test-app-tarball-url
create_react_app --scripts-version=react-scripts-fork test-app-fork
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least test something. Perhaps that the created project contains the corresponding fork in node_modules.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some asserts.

@ghost ghost added the CLA Signed label Sep 19, 2016
@gaearon gaearon merged commit 36d6868 into facebook:master Sep 19, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 19, 2016

Yay. Thank you so much!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants