Configurable eslint-loader #6973
Conversation
caub
requested review from
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb,
petetnt and
Timer
as code owners
| ignore: false, | ||
| useEslintrc: false, | ||
| quiet: !!process.env.RS_ESLINT_QUIET, |
There was a problem hiding this comment.
configurable quiet as well, for example when upgrading an old project, you can have thousands of warnings temporarily
| extends: [require.resolve('eslint-config-react-app')], | ||
| }, | ||
| useEslintrc: !!process.env.RS_ESLINTRC, |
There was a problem hiding this comment.
RS_ESLINTRC is the main point of this PR, when this env var is defined, baseConfig is not used, and a local .eslintrc is used
|
What's the point of adding this behind a env variable? Couldn't we simply detect the existence of an eslintrc file and automatically enable it? |
|
Before merging something like this in we will have to look into what options we have for extending our /cc @mrmckeb |
|
@FezVrasta I first tried to keep backward compatibility, but your idea looks better, I pushed a commit for this |
|
@mrmckeb Thanks, yes it does |
|
I'm closing this off for now in favour of the PR discussed, and am definitely open to extending that to support more ESLint formats in the near future. Thanks for your work here. |
This a very simple, and backward compatible PR to allow to a custom .eslintrc to be used