Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Babel configuration to babel-preset-react-app #701

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Sep 22, 2016

Discussed in #674.

Test plan:
Verified that npm start, npm run build and npm test work after reinstalling the packages.

@ghost ghost added the CLA Signed label Sep 22, 2016
@gaearon gaearon added this to the 0.5.0 milestone Sep 22, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 22, 2016

I think it is failing because of #699.

The reason I wasn’t using bundledDependencies in e2e before is precisely that: Travis runs out of memory trying to bundle them.

@ghost ghost added the CLA Signed label Sep 22, 2016
@fson
Copy link
Contributor Author

fson commented Sep 22, 2016

How should we fix that? I added bundledDependencies to e2e so it would use the packages from the repo – otherwise npm pack discards the node_modules and create-react-app will install our packages from npm.

@gaearon
Copy link
Contributor

gaearon commented Sep 22, 2016

Can we make it only bundle our packages?

@gaearon gaearon merged commit 5b85a36 into facebook:master Sep 22, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 22, 2016

Going to get this in and figure out e2e later.

@fson fson deleted the babel-preset branch September 22, 2016 19:18
@fson fson mentioned this pull request Sep 22, 2016
@gaearon gaearon mentioned this pull request Sep 22, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants