Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix env-cmd example in deployment section #7039

Merged
merged 1 commit into from
May 14, 2019

Conversation

VMois
Copy link
Contributor

@VMois VMois commented May 13, 2019

Related issue #6995

@VMois VMois requested review from amyrlam and iansu as code owners May 13, 2019 09:42
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@VMois
Copy link
Contributor Author

VMois commented May 13, 2019

env-cmd have changed a little bit. Reference to the current working example - https://github.com/toddbluhm/env-cmd-examples/blob/master/file-example/package.json . Based on this example, I have updated docs.

@iansu
Copy link
Contributor

iansu commented May 13, 2019

Thanks. This looks good but you have to sign the CLA before we can accept it.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu iansu added this to the 3.0.2 milestone May 14, 2019
@iansu iansu merged commit 394e385 into facebook:master May 14, 2019
@iansu
Copy link
Contributor

iansu commented May 14, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators May 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants