Improve breaking changes info for CRA 3.0.0 #7086
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
falldowngoboone
force-pushed
the
falldowngoboone-improve-breaking-changes
branch
from
3484104 to
530aa3a
Compare
CHANGELOG.md
Outdated
| @@ -201,7 +206,6 @@ You can now include a version of Normalize.css in your project that will use you | |||
|
|
|||
| - `react-scripts` | |||
| - [#6845](https://github.com/facebook/create-react-app/pull/6845) Change CRA version in `react-scripts` eject warning. ([@lffg](https://github.com/lffg)) | |||
| - [#6821](https://github.com/facebook/create-react-app/pull/6821) Add custom function to generate asset manifest ([@iansu](https://github.com/iansu)) | |||
There was a problem hiding this comment.
This should still be listed here.
CHANGELOG.md
Outdated
| @@ -129,6 +129,10 @@ The `browserslist` config in your `package.json` is now used to control the outp | |||
|
|
|||
| We've removed the `--no-watch` flag from the `start` script in favor of Jest's own `--watchAll=false`. | |||
|
|
|||
| ### New structure in `asset-manifest.json` | |||
|
|
|||
| All paths have been moved inside of the `files` key inside `asset-manifest.json`. | |||
There was a problem hiding this comment.
| All paths have been moved inside of the `files` key inside `asset-manifest.json`. | |
| All asset paths have been moved under the `files` key in `asset-manifest.json`. |
I'm adding facebook#6821 to breaking changes as this causes any existing script that relies on the structure of `assest-manifest` to break.
falldowngoboone
force-pushed
the
falldowngoboone-improve-breaking-changes
branch
from
530aa3a to
609aa82
Compare
|
@iansu, I've addressed your comments. |
|
Thanks! |
I'm moving #6821 from enhancements to breaking changes as this causes any existing script that relies on the structure of
assest-manifestto break.