Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum Node versions in docs #7182

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Update minimum Node versions in docs #7182

merged 1 commit into from
Jul 10, 2019

Conversation

JESii
Copy link
Contributor

@JESii JESii commented Jun 6, 2019 •
edited by iansu
Loading

Closes #7181

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JESii
Copy link
Contributor Author

JESii commented Jun 6, 2019

Can't imagine why some of the checks failed -- I made a one-line change on README.md :=)

@stale
Copy link

stale bot commented Jul 6, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jul 6, 2019
@JESii
Copy link
Contributor Author

JESii commented Jul 7, 2019

All checks have passed, and there are no conflicts. Should be able to be merged... yes?

@stale stale bot removed the stale label Jul 7, 2019
@iansu iansu added this to the 3.0.2 milestone Jul 10, 2019
@iansu iansu merged commit 00b5fa9 into facebook:master Jul 10, 2019
@iansu
Copy link
Contributor

iansu commented Jul 10, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Jul 15, 2019
@iansu iansu changed the title Fix issue #7181 Update minimum Node versions in docs Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

DOCS: Version 9.10.0 doesn't work as stated in docs
3 participants
@JESii @facebook-github-bot @iansu