Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove an outdated TypeScript-related note #7260

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

MidnightDesign
Copy link
Contributor

Maybe this was changed at some point in TypeScript.

There is no error because the file has imports.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu
Copy link
Contributor

iansu commented Jun 21, 2019

Do you have a reference to where this was fixed?

@MidnightDesign
Copy link
Contributor Author

Nope, I couldn't find anything. I just didn't get the error. You will get the error if you create a .ts file with no imports and no exports. But as soon as the file has at least one import (but no exports) it's gone. So I'm guessing this is something that behaved differently at some point.

@stale
Copy link

stale bot commented Jul 22, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jul 22, 2019
@iansu iansu added this to the 3.1 milestone Jul 22, 2019
@iansu iansu merged commit ad51d62 into facebook:master Jul 22, 2019
@iansu
Copy link
Contributor

iansu commented Jul 22, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants