Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect app's eslintrc #7369

Closed
wants to merge 1 commit into from
Closed

Conversation

chyipin
Copy link
Contributor

@chyipin chyipin commented Jul 14, 2019

Allow react app to configure eslint without resorting to eject

Test Instructions

  1. npm link react-scripts globally
  2. create new create-react-app
  3. npm link react-scripts in new app
  4. modify eslintConfig in package.json as follows:
    "extends": [
      "eslint:recommended",
      "react-app"
    ]
  1. exercise the script, e.g.:
    npm run build
  2. verify output
./src/serviceWorker.js
  Line 44:  Unexpected console statement  no-console
  Line 72:  Unexpected console statement  no-console
  Line 85:  Unexpected console statement  no-console
  Line 97:   Unexpected console statement  no-console
  Line 123:  Unexpected console statement  no-console

Allow react app to configure eslint without resorting to eject
@mrmckeb
Copy link
Contributor

mrmckeb commented Jul 15, 2019

Hi @chyipin, thanks for your time here, but this is a duplicate of #7036, which will resolve this.

@mrmckeb mrmckeb closed this Jul 15, 2019
@chyipin
Copy link
Contributor Author

chyipin commented Jul 15, 2019

Thanks for the heads up. I'll follow the other PR.

@chyipin chyipin deleted the support-app-eslintrc branch July 15, 2019 16:07
@lock lock bot locked and limited conversation to collaborators Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants