Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursively copy the template folder #74

Merged
merged 2 commits into from
Jul 22, 2016
Merged

Recursively copy the template folder #74

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda80e4
Recursively copy the template folder
eanplatter Jul 22, 2016
ab5259e
add fs-extra library
eanplatter Jul 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 33 additions & 19 deletions scripts/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,25 +35,39 @@ module.exports = function(hostPath, appName, verbose) {
);

// Copy the files for the user
function copySync(src, dest) {
return fs.writeFileSync(dest, fs.readFileSync(src));
function copyFileSync(src, dest) {
var target = dest;
if (fs.existsSync(dest)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is never going to happen right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the file is never going to exist? Yeah I guess not. Updating...

if (fs.lstatSync(dest).isDirectory()) {
target = path.join(dest, path.basename(src));
}
}
fs.writeFileSync(target, fs.readFileSync(src));
}
fs.mkdirSync(path.join(hostPath, 'src'));
fs.readdirSync(path.join(selfPath, 'template/src')).forEach(function(filename) {
copySync(
path.join(selfPath, 'template/src', filename),
path.join(hostPath, 'src', filename)
);
});
fs.readdirSync(path.join(selfPath, 'template')).forEach(function(filename) {
if (fs.lstatSync(path.join(selfPath, 'template', filename)).isDirectory()) {
return
}
copySync(
path.join(selfPath, 'template', filename),
path.join(hostPath, filename)
);
});

function copyFolderSync(src, dest) {
var files = [];
Copy link
Contributor

@vjeux vjeux Jul 22, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: two space indent please

var targetFolder = path.join(dest, path.basename(src)).replace('/template', '');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not safe to use / as on windows it may be \

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you do that in the call site. It's confusing to have a generically named function copyFolderSync that replaces some hardcoded path. Especially since you're recursively calling it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense. I'll find another way to do it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path.resolve(base, '..') works cross platform

if (!fs.existsSync(targetFolder)) {
fs.mkdirSync(targetFolder);
}
if (fs.lstatSync(src).isDirectory()) {
files = fs.readdirSync(src);
files.forEach(function (file) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove space between function and (

var currentSrc = path.join(src, file);
if (fs.lstatSync(currentSrc).isDirectory()) {
copyFolderSync(currentSrc, targetFolder);
} else {
copyFileSync(currentSrc, targetFolder);
}
} );
Copy link
Contributor

@vjeux vjeux Jul 22, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove space between } and )

}
}

copyFolderSync(
path.join(selfPath, 'template'),
hostPath
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing ;


// Run another npm install for react and react-dom
console.log('Installing react and react-dom from npm...');
Expand All @@ -71,7 +85,7 @@ module.exports = function(hostPath, appName, verbose) {

// Make sure to display the right way to cd
var cdpath;
if (path.join(process.cwd(), appName) == hostPath) {
if (path.join(process.cwd(), appName) === hostPath) {
cdpath = appName;
} else {
cdpath = hostPath;
Expand Down