Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dependencies to bootstrap article when using custom SCSS. #7462

Merged
merged 2 commits into from
Aug 1, 2019

Conversation

eclectic-coding
Copy link
Contributor

Added a missing dependency and instructions to install to use a custom SCSS for using custom themes. In this case node-scss is required.

Thank you for the opportunity to contribute.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

To enable `scss` in Create React App you will need to install `node-scss`:

```sh
yarn add node-scss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean node-sass? Also please show the instructions for npm and yarn, similar to the bootstrap installation instructions.

@iansu iansu added this to the 3.1 milestone Aug 1, 2019
@iansu iansu merged commit 032cdf7 into facebook:master Aug 1, 2019
@iansu
Copy link
Contributor

iansu commented Aug 1, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants