Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript init: suggest jsx: "react" in tsconfig #7472

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Typescript init: suggest jsx: "react" in tsconfig #7472

merged 1 commit into from
Aug 4, 2019

Conversation

itsMapleLeaf
Copy link
Contributor

Transpilation is done by Babel, which ignores the tsconfig, so this setting (or any tsconfig setting) doesn't affect compilation, only type checking.

Setting it to react raises a type error if react is not imported, and gives a quick fix to import react. The linter rule does not give a quick fix.

image

I've set it to suggest the value react instead of forcing it, because people might need to set it to something else in their project for whatever reason.

Verified that it works by cloning create-react-app from master, installing the local versions, and using it to compile a personal project. Setting "jsx": "react" does not affect the build size or content.

image

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz merged commit 30fc0bf into facebook:master Aug 4, 2019
@ianschmitz
Copy link
Contributor

Thanks @kingdaro. This is a good improvement.

@lock lock bot locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants