Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #7473

Merged
merged 9 commits into from
Aug 8, 2019
Merged

Bump dependencies #7473

merged 9 commits into from
Aug 8, 2019

Conversation

ianschmitz
Copy link
Contributor

Bump minor/patch versions of packages in preparation for 3.1 release.

@mrmckeb
Copy link
Contributor

mrmckeb commented Aug 5, 2019

Looks good, but I noticed the CI was cancelled?

@ianschmitz
Copy link
Contributor Author

Looks good, but I noticed the CI was cancelled?

There's actually an issue it looks like. Two test suites are failing. CLI locks then the build times out after 60 mins of waiting it appears. 😕

@mrmckeb
Copy link
Contributor

mrmckeb commented Aug 7, 2019

Strange, thanks @ianschmitz. Let's keep chasing it.

@ianschmitz
Copy link
Contributor Author

@iansu @mrmckeb I tracked down the tests hanging issue. It was caused by
a newer version of webpack-dev-server.

It appears to be having issues connecting to the websocket from jsdom:

TypeError: Cannot read property '_cookieJar' of null
at resolve (node_modules/jsdom/lib/jsdom/living/websockets/WebSocket-impl.js:124:39)
at WebSocketImpl.openingQueues.set.openingQueues.get.then (node_modules/jsdom/lib/jsdom/living/websockets/WebSocket-impl.js:112:94)

There's a related issue over at Jest: jestjs/jest#8613.

It may be connected to our usage of sockjs-client in webpackHotDevClient.js (just a hunch).

I walked back a few versions to 3.6.0 and it was still exhibiting the issue so i left the version where it was for now.

@iansu I fixed an issue with the DnyamicImport test suite. It was failing with a console error but the test was passing. I've fixed that here.

There's still a few warnings when running the test suites but i don't think there's anything we can do in the short term.

@iansu
Copy link
Contributor

iansu commented Aug 8, 2019

Bumping Lerna is a bit scary. There are always issues when we publish. If that happens I'll just revert it.

@ianschmitz ianschmitz merged commit 91c2673 into facebook:master Aug 8, 2019
@ianschmitz ianschmitz deleted the update-deps branch August 8, 2019 21:12
@lock lock bot locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants