Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block static files in robots.txt #7508

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Don't block static files in robots.txt #7508

merged 2 commits into from
Aug 12, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Aug 10, 2019

This was introduced in #7482

@iansu
Copy link
Contributor Author

iansu commented Aug 10, 2019

I know I also have to update the TypeScript template. I was trying to do this through GitHub.

Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ditch the file completely or do you think it still has value?

@ianschmitz ianschmitz added this to the 3.1.1 milestone Aug 11, 2019
@iansu
Copy link
Contributor Author

iansu commented Aug 11, 2019

We should probably release 3.1.1 with this fix.

@iansu
Copy link
Contributor Author

iansu commented Aug 11, 2019

@ianschmitz I believe it's necessary to get the 100% score on Lighthouse.

@mrmckeb
Copy link
Contributor

mrmckeb commented Aug 11, 2019

Yes, let's leave the file - we as we want to retain that 100%. It's a good win.

@iansu iansu merged commit a21e6b1 into master Aug 12, 2019
@iansu iansu deleted the iansu-patch-1 branch August 14, 2019 02:42
@lock lock bot locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants