Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Netlify config #7527

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Update Netlify config #7527

merged 2 commits into from
Aug 13, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Aug 13, 2019

Closes #7523

@iansu iansu requested a review from amyrlam as a code owner August 13, 2019 16:59
@iansu
Copy link
Contributor Author

iansu commented Aug 13, 2019

This appears to work now. Thanks to @sw-yx for helping! ❤️

@iansu iansu added this to the 3.1.1 milestone Aug 13, 2019
@iansu iansu merged commit 4a84cd4 into facebook:master Aug 13, 2019
@iansu iansu deleted the fix-netlify-previews branch August 13, 2019 17:03
@petetnt
Copy link
Contributor

petetnt commented Aug 13, 2019

Thanks @iansu!

@lock lock bot locked and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.

[docs] Deploy previews are broken due to baseUrl-issues
3 participants
@iansu @petetnt @facebook-github-bot