Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dotenv-expand to fix issues #7531

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Upgrade dotenv-expand to fix issues #7531

merged 1 commit into from
Sep 11, 2019

Conversation

sekoyo
Copy link
Contributor

@sekoyo sekoyo commented Aug 14, 2019

Hi,

This fixes issues #4002 and #5833. Fixes #7577.

Essentially if a .env has an override which is an empty string, it is ignored. This was fixed by motdotla/dotenv-expand#18

@kireerik
Copy link
Contributor

@iansu Can we merge this?

@heyimalex
Copy link
Contributor

@kireerik Could you help double-checking this for any breaking changes that could affect us?

@kireerik
Copy link
Contributor

@heyimalex Sure. It looks good to me.

@ianschmitz ianschmitz added this to the 3.1.2 milestone Sep 11, 2019
@ianschmitz ianschmitz closed this Sep 11, 2019
@ianschmitz ianschmitz reopened this Sep 11, 2019
@ianschmitz ianschmitz changed the title Upgrade dotenv-expand to fix issues #4002 #5833 Upgrade dotenv-expand to fix issues Sep 11, 2019
@ianschmitz ianschmitz merged commit edb3411 into facebook:master Sep 11, 2019
@lock lock bot locked and limited conversation to collaborators Sep 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dotenv-expand (again) to 5.x to resolve previously closed issues
5 participants