Disable babel-loader's cacheCompression #7633
Conversation
`cacheCompression` is an enabled-by-default flag in babel-loader, which gzips the babel-loader cache. Most projects do not actually benefit from cache compression, especially in production where builds often happen in a CI environment where memory is precious and disk space is not. Furthermore, having it disabled in dev and enabled in prod means caching won't be shared between dev and prod. Finally, the disk space savings are not that great. Most React projects will have a lot of small files (one file per component). babel-loader caches each file as a unit, so the compression overhead increases when the project is mainly lots of small files. For these reasons, we're disabling cache compression. Closes #6846
jleclanche
requested review from
bugzpodder,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Signed |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Dunno why the builds are failing but seems unrelated to this PR: |
|
Seems like a reasonable change. Let's try it out. Hopefully we'll see some perf improvements for our users! |
Context: #6846 - I received no feedback on it, so I figure a PR is more actionable.
Changes have been tested running on a live website since I filed the issue. Build times and their memory consumption have both decreased with no further issue arising.
cacheCompressionis an enabled-by-default flag in babel-loader,which gzips the babel-loader cache.
Most projects do not actually benefit from cache compression,
especially in production where builds often happen in a CI environment
where memory is precious and disk space is not.
Furthermore, having it disabled in dev and enabled in prod means caching
won't be shared between dev and prod.
Finally, the disk space savings are not that great. Most React projects
will have a lot of small files (one file per component). babel-loader
caches each file as a unit, so the compression overhead increases when
the project is mainly lots of small files.
For these reasons, we're disabling cache compression.
Closes #6846