Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change runtime chunk name separator from tilde to dash #7679

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Change runtime chunk name separator from tilde to dash #7679

merged 2 commits into from
Sep 13, 2019

Conversation

javadoug
Copy link
Contributor

@javadoug javadoug commented Sep 13, 2019 •
edited by ianschmitz
Loading

Fixes #5358.

npx create-react-app test-runtimechunk
cd test-runtimechunk
yarn install && yarn build

image

Then...

yarn link "react-scripts" # my fix yarn linked
yarn build

image

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@javadoug javadoug mentioned this pull request Sep 13, 2019
Closed
@ianschmitz
Copy link
Contributor

ianschmitz commented Sep 13, 2019 •
edited
Loading

Does this resolve a problem you were experiencing?

Nvm. I see the linked issue now. #5358.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz changed the title change runtime chunk name tilde is now dash (#5358) Change runtime chunk name separator from tilde to dash (#5358) Sep 13, 2019
@ianschmitz ianschmitz changed the title Change runtime chunk name separator from tilde to dash (#5358) Change runtime chunk name separator from tilde to dash Sep 13, 2019
@ianschmitz ianschmitz added this to the 3.1.2 milestone Sep 13, 2019
@javadoug
Copy link
Contributor Author

Does this resolve a problem you were experiencing?

Yes. Some firewall rules at corporations restrict URLs with characters like ~.

Reference: Article on Topic
Reference: RFC1738

@ianschmitz ianschmitz merged commit 4d533d4 into facebook:master Sep 13, 2019
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz ianschmitz approved these changes

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

How to change output filename of runtime chunk?
3 participants
@javadoug @facebook-github-bot @ianschmitz