Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new logo #7704

Merged
merged 1 commit into from
Sep 19, 2019
Merged

Add new logo #7704

merged 1 commit into from
Sep 19, 2019

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Sep 19, 2019

No description provided.

@iansu iansu merged commit ff15a08 into facebook:master Sep 19, 2019
@iansu iansu deleted the new-logo branch September 19, 2019 17:34
@lock lock bot locked and limited conversation to collaborators Sep 24, 2019
@gaearon
Copy link
Contributor

gaearon commented Oct 15, 2019

Oh. I didn’t realize we changed the template logo.

I’d like to get the template logo change reverted. People who use CRA don’t care that they use CRA specifically — they came to learn React. While it’s important for the website and the project to have a distinct identity, when you run it, it should get out of the way. That means it should be a direct path to React. So I’d like to see the React logo when you start a project.

@mrmckeb
Copy link
Contributor

mrmckeb commented Oct 15, 2019

People who use CRA don’t care that they use CRA specifically — they came to learn React

Hi @gaearon - we've researched this a few times, @iansu ran a poll too. The results show that a lot of developers are using CRA in large production applications (including members of the CRA team), and that these users are often not beginners, so I believe CRA does have meaning to those people.

That being said, I don't have strong feelings on the template logo... but I think it's worth discussing what we want CRA to be.

@gaearon
Copy link
Contributor

gaearon commented Oct 15, 2019

Did we run this poll on the whole Create React App user base? Or people who already follow us? Polls like this are often biased towards people who like to keep their hand on the pulse, and thus aren’t very representative.

Regardless, Create React App is the thing that creates an app — what you’re left with is arguably a React app. So it makes sense to me that inside a React app, we show a React logo.

@iansu
Copy link
Contributor Author

iansu commented Oct 16, 2019

It was definitely not a scientific poll, just a Twitter poll. I'll revert the logo change in the templates.

@iansu
Copy link
Contributor Author

iansu commented Oct 16, 2019

Fixed in #7830.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants