Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'shortcut' link type before 'icon' #7707

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Remove 'shortcut' link type before 'icon' #7707

merged 1 commit into from
Sep 20, 2019

Conversation

lewislbr
Copy link
Contributor

According to this MDN page,

The shortcut link type is often seen before icon, but this link type is non-conforming, ignored and web authors must not use it anymore.

So I removed it from all files except a Changelog file, which I assume is inmutable.

@iansu iansu added this to the 3.1.3 milestone Sep 20, 2019
@iansu iansu merged commit 05f7924 into facebook:master Sep 20, 2019
@iansu
Copy link
Contributor

iansu commented Sep 20, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lewislbr @iansu @facebook-github-bot