Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix module mapper regex in Flow documentation #7731

Merged
merged 1 commit into from
Sep 25, 2019
Merged

docs: fix module mapper regex in Flow documentation #7731

merged 1 commit into from
Sep 25, 2019

Conversation

FezVrasta
Copy link
Contributor

With the currently documented regex we catch relative imports, that then get wrongly mapped.

For example, ./Foobar.js will become <PROJECT_ROOT>/src/./Foobar.js, instead of <PROJECT_ROOT>/src/the/real/file/path/Foobar.js.

The new regex will exclude imports starting with a dot (.)

With the currently documented regex we catch relative imports, that then get wrongly mapped.

For example, `./Foobar.js` will become `<PROJECT_ROOT>/src/./Foobar.js`, instead of `<PROJECT_ROOT>/src/the/real/file/path/Foobar.js`.

The new regex will exclude imports starting with a dot (`.`)
@FezVrasta FezVrasta changed the title Update adding-flow.md docs: fix module mapper refex in Flow documentation Sep 25, 2019
@FezVrasta FezVrasta changed the title docs: fix module mapper refex in Flow documentation docs: fix module mapper regex in Flow documentation Sep 25, 2019
@iansu iansu merged commit 0d1775e into facebook:master Sep 25, 2019
@iansu
Copy link
Contributor

iansu commented Sep 25, 2019

Thanks!

@FezVrasta FezVrasta deleted the patch-5 branch September 25, 2019 16:59
@lock lock bot locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants