Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a flag to enable writeToDisk in dev mode #7812

Closed
wants to merge 1 commit into from

Conversation

pupudu
Copy link

@pupudu pupudu commented Oct 12, 2019

About

This PR sets up a flag to enable writing build-files to disk in development mode. As requested by issue #1070. This is quite helpful when using CRA with backends that are not written in JS, when making chrome extensions and when integrating React to a legacy UI system(eg: A UI written in PHP and react components injected in client-side).

These changes are live in a production app (made possible using the npm patch-package module). I believe it makes more sense to make it a built-in feature of CRA.

How to verify changes

  1. Start an app using react-scripts start --writeToDisk.
  2. Do a change and see build files in the production build path.

Documentation and Tests

No tests or docs have been written yet. Happy to make the PR more complete once I get the approval from the maintainers/community.

Disclaimer

This is my 1st PR to CRA. So I apologize if I have made a mistake in the contribution procedure.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Nov 11, 2019

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Nov 11, 2019
@stale
Copy link

stale bot commented Nov 16, 2019

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Nov 16, 2019
@lock lock bot locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants