-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alex to lint documentation #7852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet addition!
I think only this repo. We are able to setup GH Actions on Docusaurus. cc @JoelMarcey to enable it for CRA 😉 |
It's running on my fork so this config appears to be correct. Maybe it's not running in the PR because the config isn't present in this repo on master? I'm going to try making and merging another PR that just runs ESLint in an action. |
Okay, that actually worked in my other branch. I think this makes sense. GitHub won't run actions that are defined in PRs from a fork. Otherwise people could basically DOS your CI I guess? Or do other bad things. |
"colors", | ||
"conservative", | ||
"crashes", | ||
"executed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the software industry uses a lot of aggressive words to describe things.
This sets up Alex to lint our docs. We're also going to have to update some of the docs so they pass the linter and possibly deactivate some of the rules.
I also thought this would be a good time to try out GitHub Actions but it seems like it's not enabled on Facebook's account or maybe just this repo? 😂
cc @JoelMarcey