Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically remove testing code when ejecting. #787

Closed
wants to merge 1 commit into from
Closed

Automatically remove testing code when ejecting. #787

wants to merge 1 commit into from

Conversation

bnjmnt4n
Copy link

No description provided.

@ghost
Copy link

ghost commented Sep 28, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Sep 28, 2016
@ghost
Copy link

ghost commented Sep 28, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bnjmnt4n
Copy link
Author

Just realised this doesn't work, sorry for the wrong pull request 😭

@bnjmnt4n bnjmnt4n closed this Sep 30, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 30, 2016

Yea, unfortunately this breaks the end to end test because it is supposed to test the code after ejecting 😄 . I’d appreciate if you could look into changing our end-to-end test to kill the process when the successful compilation output is printed.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants