Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JetBrains Rider IDE as an editor #7948

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

djpowell
Copy link
Contributor

@djpowell djpowell commented Nov 8, 2019

Rider is JetBrains .NET IDE, which supports the React plugin identically to other JetBrains IDEs such as Idea and WebStorm.

Rider is JetBrains .NET IDE, which supports the React plugin identically to other JetBrains IDEs such as Idea and WebStorm.
@facebook-github-bot
Copy link

Hi djpowell! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@mrmckeb
Copy link
Contributor

mrmckeb commented Nov 11, 2019

@djpowell, does this IDE also need config files added to our template .gitignore files?

@yhnavein
Copy link

@djpowell I'm confused - Rider is for working with dotnet solutions. Why would you use for working with CRA?

There is a more suitable Jetbrains product for this kind of projects - WebStorm and it is already handled correctly in this repo.

@djpowell
Copy link
Contributor Author

@djpowell I'm confused - Rider is for working with dotnet solutions. Why would you use for working with CRA?

There is a more suitable Jetbrains product for this kind of projects - WebStorm and it is already handled correctly in this repo.

WebStorm works great, but the React plugin that WebStorm uses is available to use from IntelliJ Ultimate, Rider, and JetBrain's other IDEs too.

I'm working on a Rider solution containing a C#/ASP.NET project for the server code, and a node project containing a CRA app. This scenario was already supported with IntelliJ for Java, but not in Rider for .NET.

@petetnt
Copy link
Contributor

petetnt commented Nov 13, 2019

@mrmckeb Rider uses .idea for solution specific settings similar to other JetBrains products (https://www.jetbrains.com/help/rider/Directory_Based_Settings.html#project-level)

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mrmckeb mrmckeb added this to the 3.3 milestone Nov 17, 2019
@ianschmitz ianschmitz modified the milestones: 3.3, 3.4 Dec 5, 2019
@andriijas andriijas merged commit cc985d0 into facebook:master Jan 31, 2020
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants