Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add placeholders where old template READMEs used to be #7972

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Add placeholders where old template READMEs used to be #7972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-dev-utils/printHostingInstructions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function printHostingInstructions(
console.log();
console.log('Find out more about deployment here:');
console.log();
console.log(` ${chalk.yellow('https://create-react-app.dev/docs/deployment')}`);
console.log(` ${chalk.yellow('bit.ly/CRA-deploy')}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the placeholders make sense, but I'd keep this as https://create-react-app.dev/docs/deployment so that the end users don't have to follow 3 links to end up in the same page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever links we put in there basically have to work forever and I don't want to have a long list of old links to keep track of. We have a new domain name that we are going to switch all shortlinks over to.

console.log();
}

Expand Down
1 change: 1 addition & 0 deletions packages/react-scripts/template-typescript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This file has moved [here](https://github.com/facebook/create-react-app/blob/master/packages/cra-template-typescript/template/README.md)
1 change: 1 addition & 0 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This file has moved [here](https://github.com/facebook/create-react-app/blob/master/packages/cra-template/template/README.md)