Forbid Webpack loader syntax in imports

[fson]

Enable the no-webpack-loader-syntax, (import-js/eslint-plugin-import#586) rule in eslint-config-react-app.

Fixes #733.

Test plan:
Add this to App.js:

import 'css!./App.css';

[fson]

I don't know how to fix the e2e test. The changed peerDependencies are breaking it on npm@2 😕

[fson]

Rebased and fixed the conflicts with master. Travis is still failing on Node v4 because of peerDependencies, but I couldn't reproduce that locally, even though I tried with the same version, node v4.6.0 (npm v2.15.9).

The package.json on the root folder depends on the local eslint-config-react-app package, so it should always be the latest version and the other packages are bootstrapped with Lerna, which should symlink them correctly. But on Travis it fails to install. I wonder if this could be because of caching of node_modules.

[gaearon]

Cleared caches and restarted.

[fson]

The build is still failing, but with a different error now:

Successfully bootstrapped 5 packages.
+./node_modules/.bin/eslint --ignore-path .gitignore ./
Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-import". This can happen for a couple different reasons:

This is really weird because ESLint runs right after npm install which definitely should install eslint-plugin-import from devDependencies.

[themre]

I had a problem with installing devDeps because npm config node_env was
set to production which disabled installing devDeps. And I don't know was
this set because I didn't set this variable to production.

1. okt. 2016 4:45 pop. je oseba "Ville Immonen" notifications@github.com
   napisala:

The build is still failing, but a different error now:

Successfully bootstrapped 5 packages.
+./node_modules/.bin/eslint --ignore-path .gitignore ./
Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-import". This can happen for a couple different reasons:

This is really weird because ESLint runs right after npm install which
definitely should install eslint-plugin-import from devDependencies.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#803 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKV7ehymPb33DTsUNFSj1KE1xJWORRWfks5qy6DzgaJpZM4KLFpQ
.