-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpackHotDevClient now uses wss when https is used #8079
Conversation
Hi mikecaulley! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes perfect sense!
Ah yes. Great catch. Thanks @mikecaulley! |
Can a maintainer cut v3.3.1 release with this change please? |
Some client libraries like Facebook Login SDK will fail if run over non-HTTPS connections (even on localhost!). This makes 3.3.0 a problem for users of these libraries because they can't fall back to HTTP, even in DEV mode. So would be cool to get this patch released soon. Thanks! For folks who end up here from Google, while waiting for a patch you can manually edit protocol: window.location.protocol === 'https:' ? 'wss' : 'ws', |
Fixes #8075.
Summary
Test Plan
Follow steps in the issue #8075