Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add logging of existing default port process on start #816

Merged
merged 15 commits into from
Nov 22, 2016
Merged

add logging of existing default port process on start #816

merged 15 commits into from
Nov 22, 2016

Commits on Oct 1, 2016

  1. add logging of existing port process on start

    Ian McNally committed Oct 1, 2016
    Configuration menu
    Copy the full SHA
    626c8d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2016

  1. Move port process wording in start command on to next line

    Ian McNally committed Oct 2, 2016
    Configuration menu
    Copy the full SHA
    dc824f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2016

  1. Color the named processes as cyan in terminal output

    Ian McNally committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    abeca8a View commit details
    Browse the repository at this point in the history

  2. Add handling for multiple processes on a part 

    - With the currently process filtering, if multiple processes are returned as running on port 3000, this command would fail. This splits apart the process IDing and the process naming, to support multiple processes.
- One curious thing about the bash command to get processes, is that it'll include browsers with a window open on localhost:3000. May want to reconsider that.
    Ian McNally committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    c08a9e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2016

  1. Add process directory to existing port warning 

    - also moved terminal coloring up, when getting the process, to be able to distinguish the process command from the directory
    @ianmcnally
    ianmcnally committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    e8d0053 View commit details
    Browse the repository at this point in the history

  2. Change output color to all cyan, except "in"

    @ianmcnally
    ianmcnally committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    e3dcaaf View commit details
    Browse the repository at this point in the history

  3. Rename getProcessNameOnPort -> getProcessForPort 

    - better reflects its broadened scope (both command and directory)
    @ianmcnally
    ianmcnally committed Oct 6, 2016
    Configuration menu
    Copy the full SHA
    9c2e3aa View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2016

  1. Add checking if process is a CRA instance, to customize port running … 

    …message

- moved from using package.json to a regex, for reliability
    @ianmcnally
    ianmcnally committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    52e70f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2016

  1. Move getProcessForPort to react-dev-utils 

    - also allowed for breakdown of commands into helper methods
    @ianmcnally
    ianmcnally committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    85e8151 View commit details
    Browse the repository at this point in the history

  2. Add documentation for getProcessForPort

    @ianmcnally
    ianmcnally committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    29be9d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2016

  1. Add getProcessForPort to list of dev-scripts files

    @ianmcnally
    ianmcnally committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    97e32ca View commit details
    Browse the repository at this point in the history

  2. Use app's package name when CRA app is running on another port

    @ianmcnally
    ianmcnally committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    43fd7bc View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2016

  1. Filter port process by those listening 

    - Removed the handling of multiple process IDs since you can filtering by listening process (and not have the browser in the list of processes)
- Trimmed the terminal outputs for better matching (process id) and better terminal output (directory of process)
    @ianmcnally
    ianmcnally committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    89ffa37 View commit details
    Browse the repository at this point in the history

  2. Update README on port helpers, to specify only one port returned

    @ianmcnally
    ianmcnally committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    e25f113 View commit details
    Browse the repository at this point in the history

  3. Add ignore of stderr when executing process commands 

    - Make sure any potential errors don't leak to the user
    @ianmcnally
    ianmcnally committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    03122b5 View commit details
    Browse the repository at this point in the history