Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace favicon in templates #8194

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Conversation

heyimalex
Copy link
Contributor

The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors.

Closes #7957

Here's an example of how it looks in light and dark browsers:

view

I honestly have no idea why the size grew 5x and I'm going to try and figure out why.

The old favicon was the same as the official react documentation, which is a minor annoyance during development when trying to find the tab you want. The new favicon is just the old with inverted colors.

Closes facebook#7957
@heyimalex
Copy link
Contributor Author

The prior favicon was small because it used embeded pngs instead of bmps. I couldn't find a way to combine a bunch of pngs into an ico so I wrote one. Pretty annoying, but all of the original embedded sizes are accounted for.

Here's the source png if anyone has a better way.

original-Recovered64

@heyimalex heyimalex marked this pull request as ready for review December 19, 2019 02:59
@mrmckeb
Copy link
Contributor

mrmckeb commented Dec 19, 2019

Looks great @heyimalex, happy for you to merge ;)

@ianschmitz ianschmitz added this to the 3.3.1 milestone Dec 22, 2019
@heyimalex heyimalex merged commit c03bb36 into facebook:master Dec 30, 2019
@lock lock bot locked and limited conversation to collaborators Jan 4, 2020
@gaearon
Copy link
Contributor

gaearon commented Apr 28, 2020

The inverted comments look a bit odd IMO. I'm not a designer though.

@facebook facebook unlocked this conversation Apr 28, 2020
gaearon added a commit that referenced this pull request Apr 28, 2020
gaearon added a commit that referenced this pull request Apr 28, 2020
@gaearon
Copy link
Contributor

gaearon commented Apr 28, 2020

I'm going to revert this.

I'd prefer to be involved in any discussion that involve branding (logo, icons). This stuff matters and ideally someone with design background should be involved in upgrading or changing these.

I empathize with the original problem but this solution isn't quite good enoungh.

@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: a red favicon
6 participants