Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Disallow:" to robots.txt #8255

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Add "Disallow:" to robots.txt #8255

merged 1 commit into from
Jan 30, 2020

Conversation

tomoyaf
Copy link
Contributor

@tomoyaf tomoyaf commented Dec 29, 2019

The default robots.txt is incorrect, so I set it valid.

@tomoyaf
Fix robots.txt
03c1e0b 
Fix robots.txt
@facebook-github-bot
Copy link

Hi tomoyaf! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@tomoyaf tomoyaf changed the title Fix robots.txt Add "Disallow:" to /public/robots.txt Jan 1, 2020
@ianschmitz ianschmitz added this to the 3.3.1 milestone Jan 30, 2020
@ianschmitz ianschmitz changed the title Add "Disallow:" to /public/robots.txt Add "Disallow:" to robots.txt Jan 30, 2020
@ianschmitz ianschmitz merged commit ed162a3 into facebook:master Jan 30, 2020
@ianschmitz
Copy link
Contributor

Thanks!

@Kamahl19
Copy link
Contributor

What about the TS template? :) https://github.com/facebook/create-react-app/blob/master/packages/cra-template-typescript/template/public/robots.txt

@Kamahl19 Kamahl19 mentioned this pull request Jan 31, 2020
Merged
@tomoyaf tomoyaf deleted the patch-1 branch January 31, 2020 12:32
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tomoyaf @facebook-github-bot @ianschmitz @Kamahl19