Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade open from 7.0.0 to 6.4.0 #8364

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Downgrade open from 7.0.0 to 6.4.0 #8364

merged 1 commit into from
Jan 23, 2020

Conversation

vince1995
Copy link
Contributor

@vince1995 vince1995 commented Jan 23, 2020

Note: The vulnerability described in #7908 affects only open versions 0.0.5 and lower. Readme in open says:

The original open package was previously deprecated in favor of this package, and we got the name, so this package is now named open instead of opn. If you're upgrading from the original open package (open@0.0.5 or lower), keep in mind that the API is different.

Why?

Actively maintained.

  • Supports app arguments.
  • Safer as it uses spawn instead of exec.
  • Fixes most of the open original node-open issues.
  • Includes the latest xdg-open script for Linux.
  • Supports WSL paths to Windows apps under /mnt/*.

@andriijas

@facebook-github-bot
Copy link

Hi vince1995! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andriijas andriijas added this to the 3.3.1 milestone Jan 23, 2020
@andriijas andriijas merged commit 4bf14fa into facebook:master Jan 23, 2020
@andriijas
Copy link
Contributor

Thanks @vince1995

@lock lock bot locked and limited conversation to collaborators Jan 28, 2020
@andriijas
Copy link
Contributor

@vince1995 open v7.0.2 is out now with fixes, if you'd like to check if it works in wsl with cra it would be appreciated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3,3.0] Unable to open browsers on WSL
3 participants